This repository has been archived by the owner on Jan 24, 2023. It is now read-only.
Ingress support and dynamically set apiserver's memory #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
As mentioned in allegroai/clearml-server-helm#3, I have created a PR that allows developers to quickly setup their ingress. This can be done by using:
Once
ingress.enabled
is set totrue
theingress.host
parameter is required (but I didn't find a way to throw an exception if not set). Annotations and secretName are up to developers in case needed.The above should generate this YAML:
I have also moved the
containers.resources
tovalues.yaml
so that it will be easier to change in case needed:This can be set by using:
--set apiserver.resources.requests.memory="500m" --set apiserver.resources.limits.memory="500m"
What do you think?
Thank you!
Shaked