Volume-mesh intersections with view position texture #259
+30
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frasercl
requested review from
toloudis and
ascibisz
and removed request for
a team
toloudis
approved these changes
Nov 12, 2024
src/constants/shaders/raymarch.frag
Outdated
| float depth = texture2D(textureDepth, vUv).r; | ||
| // Sample the depth/position texture | ||
| // This is EITHER a view space position or a depth value we'll convert to a view space position | ||
| vec4 meshViewPos = texture2D(textureDepth, vUv); |
There was a problem hiding this comment.
Nit/optional: naming is a little weird here as this value might not be in view space yet
src/constants/shaders/raymarch.frag
Outdated
| vec4 meshProj = vec4(vUv * 2.0 - 1.0, depth * 2.0 - 1.0, 1.0); | ||
| vec4 meshView = inverseProjMatrix * meshProj; | ||
| vec4 meshObj = inverseModelViewMatrix * vec4(meshView.xyz / meshView.w, 1.0); | ||
| if (hasDepthValue || (usingPositionTexture == 1 && meshViewPos.a > 0.0)) { |
There was a problem hiding this comment.
I think this could use an extra comment up above to say what r,g,b,a of the position texture are expected to represent. You might even mention that this is a data format contract with Simularium viewer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
review time: small (~5min)
#237 added proper intersections between volumes and meshes. This works in the fragment shader by:
Getting volume-mesh intersections right was motivated in part by plans to incorporate volume rendering into Simularium. But Simularium's initial render pass generates a buffer of view space positions, which lets us skip step two above. This change adds support for using that view space buffer for intersections.