Add apple-touch-icon
#2752
Merged
Add apple-touch-icon
#2752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged. This looks great, thank you! For now, let's place the SVG under /resources. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1588
I took the CSS box shadow–based icon in the GoAccess site header and made an SVG out of it. To create the
apple-touch-icon, I exported this SVG with a1px#585858border and8pxof padding on all four sides. I tested the icon below on my iPhone 11 Pro Max, and can confirm that it appears as intended.(The site's favicon has two rows in the top section, while the icon in the header only has one; I added the second row so that the
apple-touch-iconand the favicon match.)I wanted to recreate the favicon as well, to ensure they were sourced from the same image, but I was unable to get a base64 version that was as small as the current one.
Happy to make any desired tweaks. If you'd like the SVG logo added to the repository, please let me know where I should place it.