feat: add eip-7702 helpers #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
force-pushed
the
onbjerg/eip-7702
branch
from
26a7009
to
bca4239
Compare
onbjerg
requested review from
DaniPopes,
gakonst,
mattsse,
prestwich and
Evalir
as code owners
mattsse
requested changes
Jun 20, 2024
Rjected
suggested changes
Jun 20, 2024
mattsse
requested changes
Jun 20, 2024
mattsse
approved these changes
Jun 20, 2024
Rjected
reviewed
Jun 20, 2024
mattsse
requested changes
Jun 20, 2024
rakita
reviewed
Jun 21, 2024
|
|
||
| /// A signed EIP-7702 authorization. | ||
| #[derive(Debug, Clone, RlpEncodable, RlpDecodable)] | ||
| pub struct SignedAuthorization<S> { |
There was a problem hiding this comment.
Can we add RecoveredAuthorization? Where we will cache the recovered account as Option<Address (Option as it can fail).
Recovery can be expensive and can be done before revm gets called. We are okay to do that as it is covered by gas.
The idea that I have is to have an enum in Revm as input:
AuthorisationList {
Recovered(Vec<RecoveredAuthorization>),
Signed(Vec<SignedAuthorization>),
}
rakita
reviewed
Jun 21, 2024
| @@ -70,6 +70,7 @@ serde = [ | |||
| kzg = ["kzg-sidecar", "sha2", "dep:derive_more", "dep:c-kzg", "dep:once_cell"] | |||
| kzg-sidecar = ["sha2"] | |||
| sha2 = ["dep:sha2"] | |||
| k256 = ["alloy-primitives/k256"] | |||
There was a problem hiding this comment.
Would be good to have seck256k1 lib/feature flag as it is faster. But looking at it as a low priority.
mattsse
approved these changes
Jun 21, 2024
3 tasks
DaniPopes
approved these changes
Jun 24, 2024
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
* feat: add eip-7702 auth list types * chore: fmt * chore: no_std * feat: add k256 feature to alloy-eips * chore: const fns * chore: lint * chore: rm vec type alias * feat: split into signed/unsigned types * fix: use `signature_prehash` * chore: fmt * chore: const fn * docs: fix doc link * chore: fmt -.- * chore: make pub * chore: cleanup * fix: error on list longer than 1 for nonce * chore: const fn -.- * feat: default derive * chore: manual decode impl for `OptionalNonce` * docs: small driveby link nits * test: add small rt ser/de tests * feat: add `RecoveredAuthorization` * fix: partial move
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
EIP-7702 is up for inclusion in Prague.
Solution
Adds helpers and some types specified in EIP-7702.
The transaction type itself will be added in another PR as it is not relevant right now (for example, the RPC spec has not been updated yet).
This also adds a
k256feature toalloy_eipssince authority recovery requires signature recovery which is only possible withk256enabled inalloy_primitivesPR Checklist