EIP-7702: change chain_id type to U256 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
programskillforverification
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
prestwich
as code owners
programskillforverification
changed the title
mattsse
requested changes
Dec 23, 2024
crates/eip7702/src/auth_list.rs
Outdated
| @@ -48,7 +48,7 @@ impl RecoveredAuthority { | |||
| pub struct Authorization { | |||
| /// The chain ID of the authorization. | |||
| #[cfg_attr(feature = "serde", serde(with = "quantity"))] | |||
There was a problem hiding this comment.
this attribute is no longer necessary
crates/eip7702/src/auth_list.rs
Outdated
| @@ -62,7 +62,7 @@ impl Authorization { | |||
| /// # Note | |||
| /// | |||
| /// Implementers should check that this matches the current `chain_id` *or* is 0. | |||
| pub const fn chain_id(&self) -> u64 { | |||
| pub const fn chain_id(&self) -> U256 { | |||
There was a problem hiding this comment.
I'd rather return an &U256 here and leave the copy up to the caller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
close #20