Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/mpp 506/activate in page v2 automatically if in page v1 was activated #195

Conversation

Benjamin-Freoua-Alma
Copy link
Member

Reason for change

Activate inpage v2 automatically

Code changes

Migration to 3.0.0 to activate automatically the inpage v2 if inpage v1 is activated

How to test

As a reviewer, you are encouraged to test the PR locally.

Installe old version of our module 2.11.2 with inpage v1, activate inpage and update the module in 3.0.0 and check if inpage is always activated

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces

Non applicable

  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • Documentation is updated (API, developer documentation, ADR, Notion...)

@sonarcloud
Copy link

sonarcloud bot commented Aug 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.1% 1.1% Duplication

@Benjamin-Freoua-Alma Benjamin-Freoua-Alma changed the base branch from main to develop August 2, 2023 12:14
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma merged commit 39f338c into develop Aug 2, 2023
3 of 4 checks passed
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma deleted the feat/MPP-506/activate-in-page-v2-automatically-if-in-page-v1-was-activated branch August 2, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants