Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Add loader on payment button ps16 if the page isn't completely loaded #244

Conversation

Benjamin-Freoua-Alma
Copy link
Member

@Benjamin-Freoua-Alma Benjamin-Freoua-Alma commented Nov 9, 2023

Reason for change

Linear task

Code changes

Add loader in payment button is page isn't completely loaded to display in-page correctly
https://components.storybook.alma.tech/?path=/story/components-button--button-primary

How to test

For Prestashop 1.6
1st Test
Install our module
Active the in-page option
Active slow 3G in network in console
And display the payment button with in-page and try to click on it

2nd Test
Active the one page checkout in the Preferences > Orders > Order process type, Save
In the front end, make the order, before click to payment button, change the quantity product (with and without eligibility)
And check the loader button and click to pay with Alma and In-Page

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

@Benjamin-Freoua-Alma Benjamin-Freoua-Alma marked this pull request as ready for review November 10, 2023 14:25
Copy link

sonarcloud bot commented Nov 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Benjamin-Freoua-Alma Benjamin-Freoua-Alma changed the title Add loader on payment button ps16 if the page isn't completely loaded [develop] Add loader on payment button ps16 if the page isn't completely loaded Nov 28, 2023
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma merged commit 747da57 into develop Nov 30, 2023
3 of 4 checks passed
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma deleted the feature/MPP-937/add-loader-on-payment-button-ps16-if-the-page-isnt-completely-loaded branch November 30, 2023 16:49
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma mentioned this pull request Nov 30, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants