[develop] Hotfix/run center 51 in page #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benjamin-Freoua-Alma
requested review from
joyet-simon,
Francois-Gomis,
ClaireAlma and
CamilleFljt
joyet-simon
approved these changes
Nov 20, 2023
Benjamin-Freoua-Alma
changed the title
Benjamin-Freoua-Alma
deleted the
hotfix/MPP-1016/run-center-51-in-page
branch
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change
Linear task
Code changes
Unmount and remove event for each payment button selector to fix if the modal isn't open before to change payment method
How to test
For Prestashop 1.7
Install our module
Activate In-Page option.
Select payment Alma with In-Page but don't click to Place Order !
And without open the modal, change the payment method and try to pay with the new payment method.
Checklist for authors and reviewers
Non applicable