-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Shipment info analysis #545
Merged
Benjamin-Freoua-Alma
merged 12 commits into
develop
from
feature/ecom-1782-ps-implement-new-call-to-store-shipping-data
Aug 12, 2024
Merged
feat: Shipment info analysis #545
Benjamin-Freoua-Alma
merged 12 commits into
develop
from
feature/ecom-1782-ps-implement-new-call-to-store-shipping-data
Aug 12, 2024
+479
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Benjamin-Freoua-Alma
force-pushed
the
feature/ecom-1782-ps-implement-new-call-to-store-shipping-data
branch
from
August 2, 2024 08:56
03ee6e4
to
d99fc00
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
webaaz
requested changes
Aug 6, 2024
…ew-call-to-store-shipping-data' into feature/ecom-1782-ps-implement-new-call-to-store-shipping-data # Conflicts: # alma/controllers/hook/ActionObjectUpdateAfter.php
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
webaaz
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's much better
Quality Gate failedFailed conditions |
⏳E2E tests are currently running. |
❌ E2E tests have failed. |
Benjamin-Freoua-Alma
changed the title
Save Alma order shipping data
feat: Save Alma order shipping data
Aug 8, 2024
Benjamin-Freoua-Alma
changed the title
feat: Save Alma order shipping data
feat: Shipment info analysis
Aug 8, 2024
Benjamin-Freoua-Alma
approved these changes
Aug 12, 2024
CamilleFljt
approved these changes
Aug 12, 2024
Benjamin-Freoua-Alma
deleted the
feature/ecom-1782-ps-implement-new-call-to-store-shipping-data
branch
August 12, 2024 09:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change
[Linear task
](https://linear.app/almapay/issue/ECOM-1782/[-ps]-implement-new-call-to-store-shipping-data)
Code changes
Add new hook
How to test
Test with old version please !
As a reviewer, you are encouraged to test the PR locally.
Checklist for authors and reviewers
Non applicable