Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Shipment info analysis #545

Conversation

Francois-Gomis
Copy link
Collaborator

Reason for change

[Linear task
](https://linear.app/almapay/issue/ECOM-1782/[-ps]-implement-new-call-to-store-shipping-data)

Code changes

Add new hook

How to test

Test with old version please !

As a reviewer, you are encouraged to test the PR locally.

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces

Non applicable

@Francois-Gomis Francois-Gomis requested a review from a team as a code owner July 31, 2024 21:29
@github-actions github-actions bot added the type: feature New feature label Jul 31, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@Benjamin-Freoua-Alma Benjamin-Freoua-Alma force-pushed the feature/ecom-1782-ps-implement-new-call-to-store-shipping-data branch from 03ee6e4 to d99fc00 Compare August 2, 2024 08:56

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

…ew-call-to-store-shipping-data' into feature/ecom-1782-ps-implement-new-call-to-store-shipping-data

# Conflicts:
#	alma/controllers/hook/ActionObjectUpdateAfter.php

This comment has been minimized.

This comment has been minimized.

Copy link
Member

@webaaz webaaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's much better

Copy link

sonarcloud bot commented Aug 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
6.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

github-actions bot commented Aug 7, 2024

⏳E2E tests are currently running.
➡️ You can follow their progression here.

Copy link

github-actions bot commented Aug 7, 2024

❌ E2E tests have failed.
➡️ You can find the results here.

@Benjamin-Freoua-Alma Benjamin-Freoua-Alma changed the title Save Alma order shipping data feat: Save Alma order shipping data Aug 8, 2024
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma changed the title feat: Save Alma order shipping data feat: Shipment info analysis Aug 8, 2024
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma merged commit 739a625 into develop Aug 12, 2024
3 of 5 checks passed
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma deleted the feature/ecom-1782-ps-implement-new-call-to-store-shipping-data branch August 12, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants