-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: HMAC verification on IPN callback for security #561
Merged
Benjamin-Freoua-Alma
merged 6 commits into
develop
from
feature/ecom-1818-ps-add-hmac-verification-on-ipn
Sep 25, 2024
Merged
feat: HMAC verification on IPN callback for security #561
Benjamin-Freoua-Alma
merged 6 commits into
develop
from
feature/ecom-1818-ps-add-hmac-verification-on-ipn
Sep 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Francois-Gomis
requested changes
Sep 18, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Francois-Gomis
approved these changes
Sep 19, 2024
⏳E2E tests are currently running. |
Quality Gate passedIssues Measures |
❌ E2E tests have failed. |
joyet-simon
approved these changes
Sep 25, 2024
Benjamin-Freoua-Alma
deleted the
feature/ecom-1818-ps-add-hmac-verification-on-ipn
branch
September 25, 2024 09:49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change
Linear task
Code changes
We add the call function to
isHmacValidated
in php client to check is the IPN callback is signed by Alma before to validate the order by IPNHow to test
As a reviewer, you are encouraged to test the PR locally.
Make an order, close the page before the return validation payment
Call the ipn callback with some other browser or API Client to check if the IPN need the Alma signature
Checklist for authors and reviewers
Non applicable