Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement PHP client endpoints into Prestashop #587

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

Benjamin-Freoua-Alma
Copy link
Member

Reason for change

Linear task

Code changes

First part : CMS is able to send the endpoint_url to backend

We create a function in clientHelper to send url for gather cms data
We create a function in apiHelper to send url for gather cms data
We use the function to send url for gather cms data after the form saved

Second part : CMS is able to return cms_collected_data to backend

Blocked by the PR front controller CMS Data

How to test

As a reviewer, you are encouraged to test the PR locally.

First part : Save the config form and see if the url of front controller for gather CMS data is send
Second part : Execute the url executed by Alma and see if the CMS data are send

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

@Benjamin-Freoua-Alma Benjamin-Freoua-Alma self-assigned this Oct 22, 2024
@github-actions github-actions bot added the type: feature New feature label Oct 22, 2024
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma marked this pull request as ready for review November 4, 2024 09:12
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma requested a review from a team as a code owner November 4, 2024 09:12

This comment has been minimized.

This comment has been minimized.

@@ -55,6 +55,14 @@ public function getModule()
return \Module::getInstanceByName(ConstantsHelper::ALMA_MODULE_NAME);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Module name is not a Param - it a getAlmaModule methode and it's an AlmaModuleFactory

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Francois-Gomis I'm not sure to understand your request. Can we speak on that in synchroniously

alma/lib/Helpers/ApiHelper.php Show resolved Hide resolved
alma/lib/Helpers/ClientHelper.php Outdated Show resolved Hide resolved
alma/lib/Helpers/CmsDataHelper.php Show resolved Hide resolved
alma/lib/Helpers/CmsDataHelper.php Outdated Show resolved Hide resolved

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link

⏳E2E tests are currently running.
➡️ You can follow their progression here.

Copy link

sonarcloud bot commented Nov 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 New Bugs (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link

❌ E2E tests have failed.
➡️ You can find the results here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants