-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement PHP client endpoints into Prestashop #587
base: develop
Are you sure you want to change the base?
feat: Implement PHP client endpoints into Prestashop #587
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@@ -55,6 +55,14 @@ public function getModule() | |||
return \Module::getInstanceByName(ConstantsHelper::ALMA_MODULE_NAME); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Module name is not a Param - it a getAlmaModule methode and it's an AlmaModuleFactory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Francois-Gomis I'm not sure to understand your request. Can we speak on that in synchroniously
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
⏳E2E tests are currently running. |
Quality Gate failedFailed conditions See analysis details on SonarQube Cloud Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE |
❌ E2E tests have failed. |
Reason for change
Linear task
Code changes
First part : CMS is able to send the endpoint_url to backend
We create a function in clientHelper to send url for gather cms data
We create a function in apiHelper to send url for gather cms data
We use the function to send url for gather cms data after the form saved
Second part : CMS is able to return cms_collected_data to backend
Blocked by the PR front controller CMS Data
How to test
As a reviewer, you are encouraged to test the PR locally.
First part : Save the config form and see if the url of front controller for gather CMS data is send
Second part : Execute the url executed by Alma and see if the CMS data are send
Checklist for authors and reviewers
Non applicable