Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Impossible configure Alma if PS Account version is lower 5.0 #589

Conversation

Benjamin-Freoua-Alma
Copy link
Member

Reason for change

Linear task

Code changes

We added a verification version of PS Account. If PS Account was lower that 5.0 PS Account Service returned an error that we didn't handle.
Now if the version is lower 5.0 we suggest to install the PS Account module (default message)

How to test

As a reviewer, you are encouraged to test the PR locally.

Install Ps Account lower that 5.0.
Install our module.
Try to configure it

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • You understand the impact of this PR on existing code/features
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • The changes include adequate logging and Datadog traces

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

alma/alma.php Outdated Show resolved Hide resolved

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

@olance olance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do a search & replace of PsAccount to PsAccounts? 😅
Just so that we're consistent with the real name.

This comment has been minimized.

@Benjamin-Freoua-Alma
Copy link
Member Author

Can you do a search & replace of PsAccount to PsAccounts? 😅 Just so that we're consistent with the real name.

@olance I replaced it 👍

This comment has been minimized.

Copy link

⏳E2E tests are currently running.
➡️ You can follow their progression here.

Copy link

sonarcloud bot commented Oct 29, 2024

Copy link

❌ E2E tests have failed.
➡️ You can find the results here.

@Benjamin-Freoua-Alma Benjamin-Freoua-Alma merged commit e6c3b39 into main Oct 30, 2024
4 of 5 checks passed
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma deleted the hotfix/ecom-2162-zepelucheclubcom-500-internal-sever-error branch October 30, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants