-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Impossible configure Alma if PS Account version is lower 5.0 #589
fix: Impossible configure Alma if PS Account version is lower 5.0 #589
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you do a search & replace of PsAccount
to PsAccounts
? 😅
Just so that we're consistent with the real name.
This comment has been minimized.
This comment has been minimized.
@olance I replaced it 👍 |
This comment has been minimized.
This comment has been minimized.
⏳E2E tests are currently running. |
Quality Gate passedIssues Measures |
❌ E2E tests have failed. |
Reason for change
Linear task
Code changes
We added a verification version of PS Account. If PS Account was lower that 5.0 PS Account Service returned an error that we didn't handle.
Now if the version is lower 5.0 we suggest to install the PS Account module (default message)
How to test
As a reviewer, you are encouraged to test the PR locally.
Install Ps Account lower that 5.0.
Install our module.
Try to configure it
Checklist for authors and reviewers
Non applicable