Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue with some translation in payment buttons #593

Conversation

Benjamin-Freoua-Alma
Copy link
Member

Reason for change

Linear task

Code changes

We created an helper to test some function with translations. But Prestashop doesn't handle the translation is the function doesn't named ->l() I renamed our function with ->l() to handle all our translation

How to test

As a reviewer, you are encouraged to test the PR locally.

Install the FR language un the store Translation > Add / Update a language > Add French
Install our module and enable de Pay later (+15/+30)
Go to the front, change the langue in FR
Go to the checkout, select a pay later and see if the payment button pay later is well translated.

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features

Non applicable

  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Copy link

⏳E2E tests are currently running.
➡️ You can follow their progression here.

Copy link

sonarcloud bot commented Oct 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
11.1% Duplication on New Code

See analysis details on SonarCloud

Copy link

❌ E2E tests have failed.
➡️ You can find the results here.

@Benjamin-Freoua-Alma Benjamin-Freoua-Alma merged commit a504025 into develop Nov 12, 2024
5 of 6 checks passed
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma deleted the fix/ecom-2147-eurl-mecatera-word-in-english-in-the-checkout-module branch November 12, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants