Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v4.4.2 #601

Closed
wants to merge 46 commits into from
Closed

Release v4.4.2 #601

wants to merge 46 commits into from

Conversation

alma-create-pr-with-team-review[bot]
Copy link

@alma-create-pr-with-team-review alma-create-pr-with-team-review bot commented Nov 13, 2024

Update version to v4.4.2

Checklist of actions to be done before merging

  • Review and update the CHANGELOG.md if needed
  • Review and update the Github release draft if needed
    ⚠️ Click on Save draft to update it, do not click on Publish release: it will be published automatically after the merge of this PR
  • Review and update the translation files after crowdin update if needed
  • Review the files updated with the new version number in the commit named "chore: update version"

alma-renovate-bot bot and others added 30 commits October 7, 2024 10:14
chore(deps): update github actions
…ge-to-fix-incompatibilities

feat: add inpage setting for selector payment buttons
…s-5.x

chore(deps): update pre-commit hook pre-commit/pre-commit-hooks to v5
Co-authored-by: alma-renovate-bot[bot] <163289924+alma-renovate-bot[bot]@users.noreply.github.com>
chore(deps): update pre-commit hook returntocorp/semgrep to v1.92.0
Instead of trying to find it from the DOM
+ use plain JS objects instead of data attributes for settings & product details
There's a bug in some PS 1.7 versions where quantity_wanted is not set to the actual quantity value
Fix insurance widget conflict with product details panel
Some versions of PS (e.g. 1.7.2.4) will completely reload the product actions DOM, causing the widget to fully reload and loose its state.
As a result, the insurance modal always uses a quantity=1 when opened via the widget.

Including the quantity in the URL fixes that
PrestaShop events are not manually triggered anymore, as we really only need to listen to them, so that we can trigger some update flows.
The rest of the control flow remains handled at the message event handler level, which removes unnecessary reloads and fixes a few other bugs
chore(deps): update pre-commit repositories
chore(deps): update mysql docker tag to v9.1
Improve insurance integration stability & prevent unnecessary reloading of widget
…-for-in-page-advanced-feature

feat: Update wording for In-Page advanced feature
chore(deps): update pre-commit hook returntocorp/semgrep to v1.95.0
…-english-in-the-checkout-module

fix: issue with some translation in payment buttons
chore(deps): update pre-commit repositories
Prevent crash when there is not quantity input on product page
Copy link

⏳E2E tests are currently running.
➡️ You can follow their progression here.

Copy link

sonarcloud bot commented Nov 13, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 New Bugs (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link
Member

@hyahiaoui hyahiaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validating the changes on the Github workflows and pre-commit config.

@Benjamin-Freoua-Alma
Copy link
Member

wrong changelog history

Copy link

❌ E2E tests have failed.
➡️ You can find the results here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants