fix: do not included downloaded assets in jekyll-minifier #2749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
george-gca
approved these changes
Oct 5, 2024
kastnerp
added a commit
to SustainableUrbanSystemsLab/SustainableUrbanSystemsLab.github.io
that referenced
this pull request
Oct 6, 2024
fix: do not included downloaded assets in jekyll-minifier (alshedivat#2749)
Hadi-loo
added a commit
to Hadi-loo/hadi-loo.github.io
that referenced
this pull request
Oct 9, 2024
fix: do not included downloaded assets in jekyll-minifier (alshedivat#2749)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
download: true, the site deployment fails.This caused e.g. issue #2548.
I believe the issue appears because the 3rd party downloaded libs rely on ES6 Syntax, which jekyll-minifier cannot work on correctly.
Also, I think we do not need to minify 3rd party downloaded libs at all.
While this PR does not fix the issue above, it at least ensures that the site can be deployed with
download: true. We still need better ES6 support as suggested in #2571.