Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve StreamEx coverage #201

Merged
merged 5 commits into from
Aug 31, 2019
Merged

Improve StreamEx coverage #201

merged 5 commits into from
Aug 31, 2019

Conversation

errandir
Copy link

PIT 1.4.3 (default mutators): 100% line and mutation coverage of StreamEx by StreamExTest

PIT 1.4.3 (default mutators): 100% line and mutation coverage of StreamEx by StreamExTest
src/main/java/one/util/streamex/StreamEx.java Outdated Show resolved Hide resolved
src/main/java/one/util/streamex/StreamEx.java Show resolved Hide resolved
src/test/java/one/util/streamex/StreamExTest.java Outdated Show resolved Hide resolved
src/test/java/one/util/streamex/TestHelpers.java Outdated Show resolved Hide resolved
# Conflicts:
#	src/test/java/one/util/streamex/StreamExTest.java
    PIT 1.4.3 (default mutators): 100% line and mutation coverage of StreamEx by StreamExTest and StreamExHeadTailTest
@coveralls
Copy link

coveralls commented Aug 28, 2019

Coverage Status

Coverage increased (+0.02%) to 99.079% when pulling 5dc29b3 on errandir:master into c7c7ae7 on amaembo:master.

@errandir
Copy link
Author

@amaembo Should I cheat Coveralls to prevent UnorderedCancellableSpliterator coverage decreasing to fulfill it's changes request? Coverage of some lines of this class has highly probabilistic nature. Only injection of synchronization points (which will be enabled only by corresponding tests) could guarantee these lines coverage.

@amaembo
Copy link
Owner

amaembo commented Aug 29, 2019

Should I cheat Coveralls to prevent UnorderedCancellableSpliterator coverage decreasing to fulfill it's changes request?

I don't think we should be that obsessed with coverage.

@amaembo
Copy link
Owner

amaembo commented Aug 29, 2019

In general looks good. I will look once more a few days later.

@amaembo amaembo merged commit a3f1ddf into amaembo:master Aug 31, 2019
@amaembo
Copy link
Owner

amaembo commented Aug 31, 2019

Thanks. Btw is it possible to integrate Travis build with PITest and get something like a mutation coverage badge or a page where dynamics is displayed in order to keep it at high level?

@errandir
Copy link
Author

errandir commented Sep 3, 2019

@amaembo Unfortunately, I haven't found any ready-to-use solution that could provide a pit badge. For now, I think that the most acceptable solution is to somehow extend coveralls plugin to parse pit maven plugin output. But there will be the need to push a separate report (maybe applying some postfix to coveralls' serviceBuildNumber), probably using maven build profiles to allow coveralls plugin process pit and jacoco results separately. Do you have any idea about this?

PS: There is an old open issue on adding pit support to coveralls plugin.

@amaembo
Copy link
Owner

amaembo commented Sep 3, 2019

Do you have any idea about this?

Nope. I wanted to add at least a branch support but it seems that coveralls-maven-plugin plugin is abandoned (this PR is more than two years old).

Btw your commits are not attributed to you for some reason. E.g. this commit is not linked to your account. I'm not sure but probably you should check the e-mail settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants