Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/function gcp #200

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Feature/function gcp #200

wants to merge 4 commits into from

Conversation

guttff
Copy link
Collaborator

@guttff guttff commented Nov 7, 2022

Description

GCP Kotlin greeter function

  • adding the revert endpoint
  • adding the uppercase endpoint
  • adding the greeter endpoint

@guttff guttff requested a review from a team as a code owner November 7, 2022 21:12
@guttff guttff requested a review from aknowles18 November 7, 2022 21:12
@@ -31,21 +35,44 @@
</dependency>

<!--Third Party-->
<dependency>
<groupId>org.jetbrains.kotlin</groupId>
<artifactId>kotlin-stdlib-jdk8</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be jdk17?

<dependency>
<groupId>org.springframework.cloud</groupId>
<artifactId>spring-cloud-gcp-starter</artifactId>
<version>1.0.0.RELEASE</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be in main pom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants