Skip to content

Commit

Permalink
fix(helm): make use of resource values for webhook (kubernetes-sigs#4560
Browse files Browse the repository at this point in the history
)

* fix(helm): make use of resource values for webhook

previously these values were omitted due to an omission in the deployment template, now they should
be accurately templated when provided to the chart

* chore(chart): add provider.webhook.resources fix to changelog
  • Loading branch information
crutonjohn authored and simonoff committed Sep 6, 2024
1 parent 9c35ee2 commit c8e8576
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
6 changes: 5 additions & 1 deletion charts/external-dns/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [UNRELEASED]

### Fixed

- Fixed `provider.webhook.resources` behavior to correctly leverage resource limits ([#4560](https://github.com/kubernetes-sigs/external-dns/pull/4560))

## [v1.14.5] - 2023-06-10

### Added
Expand Down Expand Up @@ -58,7 +62,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

- Restore template support in `.Values.provider` and `.Values.provider.name`
- Restore template support in `.Values.provider` and `.Values.provider.name`

## [v1.14.1] - 2024-01-11

Expand Down
4 changes: 4 additions & 0 deletions charts/external-dns/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,10 @@ spec:
{{- toYaml . | nindent 12 }}
{{- end }}
{{- end }}
{{- with .resources }}
resources:
{{- toYaml . | nindent 12 }}
{{- end }}
{{- with .securityContext }}
securityContext:
{{- toYaml . | nindent 12 }}
Expand Down

0 comments on commit c8e8576

Please sign in to comment.