Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Windows nameserver detection by only enumerating real NICs #114

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

Bilge
Copy link
Contributor

@Bilge Bilge commented Jan 30, 2024

Previously we were enumerating every TCPIP interface regardless of disposition, including virtual NICs, bluetooth adapters, VPNs and disabled interfaces. It is most likely the case that valid nameserver configuration can only come from real, physical devices, which we now detect by enumerating the NetworkCards key first.

Ref: https://stackoverflow.com/q/6393373/1041515

@trowski trowski merged commit 3e3f413 into amphp:2.x Jan 30, 2024
4 checks passed
@Bilge Bilge deleted the enumerate-real-keluniks branch January 30, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants