-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add integration plugin #126
Conversation
} | ||
this.integration = integration; | ||
if (integration.setup) { | ||
this.integration.setup(this.config, this.client).then( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can plugins make modifications to config, or do we want to pass in a copy of config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, interesting thought. I'm actually not quite sure what the right answer is. I kind of like the flexibility that they could change config.
Summary
ExperimentPlugin
modeled after analytics plugin interface.addPlugin
method to ExperimentClient.IntegrationPlugin
handles getting user identity and tracking exposuresinitializeWithAmplitudeAnalytics
now installs theAmplitudeIntegrationPlugin
instead ofConnectorUserProvider
andConnectorExposureTrackingProvider
.IntegrationManager
handles managingIntegrationPlugin
s for the client.Checklist