Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: track impressions for web experiments #127

Merged
merged 29 commits into from
Oct 15, 2024
Merged

feat: track impressions for web experiments #127

merged 29 commits into from
Oct 15, 2024

Conversation

bgiori
Copy link
Collaborator

@bgiori bgiori commented Sep 18, 2024

Summary

  • track impressions instead of exposure events for web experiments through integration plugin

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: no

bgiori added 17 commits September 21, 2024 11:45
@bgiori
feat: change amplitude integration plugin to be feat exp specific
9955887
@bgiori
Merge branch 'main' into integration-plugin
64297e5
@bgiori
feat: remove persistence from analytics connector; fix tests
f8f7030
@bgiori
Merge branch 'integration-plugin' into track-impressions
851945d
@bgiori
set experimentIntegration as plugin on init
b3cf5a2
@bgiori
Merge branch 'main' into integration-plugin
94a806b
@bgiori
chore: add version to tag file
4ef74dc
@bgiori
fix: dont track exposure if trackExposure metadata is false
ee6b093
@bgiori
fix: force integration type on global integration
d6892f2
@bgiori
fix: only allow one web exp instance
9a3f60b
@bgiori
fix: support feat/web exp instances w/ same key & ua target
1763ad3
@bgiori
chore: add experiment segment plugin (#128)
4d4afd4
@bgiori
fix: bind tracking call to correct object
f6cf0da
@bgiori
fix: lint
818cee7
@bgiori
fix: dont allow double initialization
d0c8ecc
@bgiori
fix: poller
f0e7d39
@bgiori
fix: test increase timeout
2859114
Base automatically changed from integration-plugin to main October 10, 2024 16:59
@bgiori bgiori changed the base branch from main to segment-plugin October 15, 2024 20:11
@bgiori bgiori closed this Oct 15, 2024
@bgiori bgiori reopened this Oct 15, 2024
@bgiori bgiori changed the base branch from segment-plugin to main October 15, 2024 20:14
@bgiori bgiori merged commit fef53e5 into main Oct 15, 2024
6 checks passed
@bgiori bgiori deleted the track-impressions branch October 15, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyiuhc tyiuhc tyiuhc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bgiori @tyiuhc