-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add patch dom mutator #146
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Nested HTML editing doesn't work with the current implementation of dom-mutator. They just released a version 0.7.1 that we should probably leverage as that has some rate limiting with the number of mutations which run a minute. That being said, it doesn't directly address the issues that we're seeing. Here's the custom dom-mutator changes that we are keying off of: https://github.com/amplitude/dom-mutator/pull/7/files. To address the infinite loop issue, the lines of interest have to do with
_textTimeout
where if you setTimeout and pause the global mutation observer, then resume it by queueing something quickly in the JS event loop usingsetTimeout
, we batch the changes together so that an element isn't being changed back and forth clobbering each other.Note
This only works because we don't expect customers to install this package directly. If they do, it'll throw an error because the repo this change points to is private. We only want to use experiment-tag as a project to generate the experiment-script.min.js template that is used by our dynamic script service, and this is called locally from our machines, which do have access to this project.
Checklist
TODO