-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement required connectionManagerService and mediaReceiverRegistrarService #86
Conversation
This reverts commit 3ac0277.
commit d5d0f56 Author: nikk gitanes <[email protected]> Date: Wed Sep 8 13:28:02 2021 +0300 proper deviceIcons serve thx @YouROK
The formatting and imports are messed up. Try running
|
This part was from rclone's https://github.com/rclone/rclone/blob/master/cmd/serve/dlna/dlna_test.go for new service, not checked it. sorry. it.s ok now: |
@anacrolix do I need to apply gofmt from go1.17 also? generates this: |
Yes please. |
Do we need any license notice from rclone? |
here we don't have direct code from rclone - just similar logic. |
Oh awesome, yes this fixes #78. Just tried it out and works great so far. Thanks for the work. |
I mentioned on the probable fix issues to try this PR. Thanks for your great work @tsynik . |
I'm considering squashing and merging this. If I can get some more feedback from users that it's working for them. Thanks again to @tsynik for the good work. |
Okay let's give it a go. I'm not hearing any more feedback and you put a lot of effort in to this. |
this fix DLNA browse on LG TVs and under Windows 10 Explorer
PR also have some addons from rclone repo for Samsung TVs (some of them still have browse issues)
Probably fix for #40 #78 #73