Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: still warn on zero verbosity #68

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Fix: still warn on zero verbosity #68

merged 3 commits into from
Nov 15, 2024

Commits on Oct 16, 2024

  1. fix: allocate stderr logger if log.Warn needed 

    Previously, there was an issue where if there was no TTY, and verbosity
was zero, the logger would be initialized with io.Discard instead of
stderr. Log to stderr unless "--quiet" is passed.

Signed-off-by: Will Murphy <[email protected]>
    @willmurphyscode
    willmurphyscode committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    ee7b891 View commit details
    Browse the repository at this point in the history

  2. feat: respect NO_TTY env var when setting up UI 

    Signed-off-by: Will Murphy <[email protected]>
    @willmurphyscode
    willmurphyscode committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    adf59de View commit details
    Browse the repository at this point in the history

  3. test: unit test for warn logging 

    Signed-off-by: Will Murphy <[email protected]>
    @willmurphyscode
    willmurphyscode committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    b98ebbb View commit details
    Browse the repository at this point in the history