Fix matching when RPM modularity is a factor #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
wagoodman
force-pushed
the
optional-modularity
branch
from
d280afd
to
b919fae
Compare
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
willmurphyscode
approved these changes
Jan 25, 2024
…r now For oraclelinux, the default stream of an installed appstream package does not currently set the MODULARITYLABEL property in the rpm metadata; however, in their advisory data they do specify modularity information, so this ends up in a case where the vuln entries have modularity but the packages coming from the sbom won't, so for now we need to treat the constraint as satisfied when the modularity label from an oraclelinux package is "". Signed-off-by: Weston Steimel <[email protected]>
Signed-off-by: Weston Steimel <[email protected]>
Signed-off-by: Weston Steimel <[email protected]>
westonsteimel
force-pushed
the
optional-modularity
branch
from
313d299
to
0f42f2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts the package qualifier for RPM modularities to take into consideration cases when the underlying package source cannot express modularity.