Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure releases only use released versions of syft #1680

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

wagoodman
Copy link
Contributor

This is an extra protection that ensures the version of syft in the go.mod is a released version of syft (not a version that is for a commit on main). This is done in both the release workflow as well as the trigger for release -- this is done in both places to help balance ease (fail as early as possible) and safety (the source of truth for all release gates must be in the release workflow).

This should allow us to continually integrate syft changes in grype more often and not require a release of syft.

@wagoodman wagoodman added the changelog-ignore Don't include this issue in the release changelog label Jan 25, 2024
@wagoodman wagoodman requested a review from a team January 25, 2024 17:54
@wagoodman wagoodman self-assigned this Jan 25, 2024
@wagoodman wagoodman marked this pull request as ready for review January 25, 2024 22:02
@wagoodman wagoodman merged commit fdf9842 into main Jan 26, 2024
10 checks passed
@wagoodman wagoodman deleted the release-gate-for-released-version-of-syft branch January 26, 2024 17:15
spiffcs added a commit to jneate/grype that referenced this pull request Feb 13, 2024
* main: (224 commits)
  fix: only warn missing CPEs if CPEs wanted (anchore#1710)
  fix: ensure version output to stdout (anchore#1709)
  chore(deps): update bootstrap tools to latest versions (anchore#1706)
  chore(deps): update Syft to v0.104.0 (anchore#1704)
  Bump Syft in Grype to pull in unmarshaling fix (anchore#1703)
  chore(deps): bump github.com/docker/docker (anchore#1702)
  chore(deps): bump gorm.io/gorm from 1.25.6 to 1.25.7 (anchore#1700)
  chore(deps): update bootstrap tools to latest versions (anchore#1698)
  chore(deps): bump actions/upload-artifact from 4.3.0 to 4.3.1 (anchore#1699)
  chore(deps): bump github.com/gkampitakis/go-snaps from 0.5.0 to 0.5.2 (anchore#1697)
  chore(deps): bump peter-evans/create-pull-request from 5.0.2 to 6.0.0 (anchore#1687)
  chore(deps): bump anchore/sbom-action from 0.15.6 to 0.15.8 (anchore#1690)
  chore(deps): bump sigstore/cosign-installer from 3.3.0 to 3.4.0 (anchore#1691)
  chore(deps): bump github.com/docker/docker (anchore#1692)
  chore(deps): bump github.com/opencontainers/runc from 1.1.5 to 1.1.12 (anchore#1689)
  Upgrade syft to v0.103.1 (anchore#1688)
  chore(deps): bump github.com/google/go-containerregistry (anchore#1685)
  chore(deps): bump anchore/sbom-action from 0.15.5 to 0.15.6 (anchore#1684)
  ensure releases only use released versions of syft (anchore#1680)
  chore(deps): bump gorm.io/gorm from 1.25.5 to 1.25.6 (anchore#1683)
  ...

Signed-off-by: Christopher Phillips <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-ignore Don't include this issue in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants