Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch to yardstick validate from custom gate.py #2090

Merged
merged 3 commits into from
Sep 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/bootstrap/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ inputs:
python-version:
description: "Python version to install"
required: true
default: "3.10"
default: "3.11"
go-dependencies:
description: "Download go dependencies"
required: true
Expand Down
7 changes: 7 additions & 0 deletions test/quality/.yardstick.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,11 @@ default_max_year: 2021
result-sets:
pr_vs_latest_via_sbom:
description: "latest released grype vs grype from the current build (via SBOM ingestion)"
validations:
- max-f1-regression: 0.0
max-new-false-negatives: 00
max-unlabeled-percent: 10
max_year: 2021
matrix:
images: *images

Expand All @@ -112,6 +117,7 @@ result-sets:
# for local build of grype, use for example:
version: path:../../+import-db=db.tar.gz
takes: SBOM
label: candidate

- name: grype
# note: we import a static (pinned) DB as to prevent changes in the DB from affecting the results. The
Expand All @@ -121,3 +127,4 @@ result-sets:
# are testing with is not too stale.
version: latest+import-db=db.tar.gz
takes: SBOM
label: reference
2 changes: 1 addition & 1 deletion test/quality/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ all: capture validate ## Fetch or capture all data and run all quality checks

.PHONY: validate
validate: venv $(VULNERABILITY_LABELS)/Makefile ## Run all quality checks against already collected data
$(ACTIVATE_VENV) ./gate.py
$(ACTIVATE_VENV) yardstick validate -r $(RESULT_SET)

.PHONY: capture
capture: sboms vulns ## Collect and store all syft and grype results
Expand Down
345 changes: 0 additions & 345 deletions test/quality/gate.py

This file was deleted.

2 changes: 1 addition & 1 deletion test/quality/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
git+https://github.com/anchore/yardstick@v0.9.1
git+https://github.com/anchore/yardstick@v0.10.0
# ../../../yardstick
tabulate==0.9.0
Loading