fix: don't accumulate result state with rhel provider #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonsteimel
added
the
run-pr-quality-gate
westonsteimel
force-pushed
the
rhel-provider-dont-accumulate-results
branch
from
6646f74
to
85b42ba
Compare
Sets the result store policy for the `rhel` provider to `DELETE_BEFORE_WRITE`. There shouldn't be a reason for the rhel provider to need to accumulate result state between runs as it always iterates over the full input set. This will address an issue where vulnerabilities marked as `not-affected` don't get dropped from the results. Signed-off-by: Weston Steimel <[email protected]>
…ore recent release Signed-off-by: Weston Steimel <[email protected]>
westonsteimel
force-pushed
the
rhel-provider-dont-accumulate-results
branch
from
85b42ba
to
25a8808
Compare
wagoodman
approved these changes
Jul 27, 2023
Signed-off-by: Weston Steimel <[email protected]>
westonsteimel
force-pushed
the
rhel-provider-dont-accumulate-results
branch
from
2e116f0
to
fea1289
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the result store policy for the
rhelprovider toDELETE_BEFORE_WRITE. There shouldn't be a reason for the rhel provider to need to accumulate result state between runs as it always iterates over the full input set. This will address an issue where vulnerabilities marked asnot-affecteddon't get dropped from the results.This also addresses an issue where vulnerability records were not being properly created for
out-of-supportentriesFixes #252