Add processor to workspace state #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Goodman <[email protected]>
wagoodman
commented
Nov 14, 2024
| @@ -1,6 +1,6 @@ | |||
| # the default is to run these on commit + push | |||
| default_stages: | |||
| - push | |||
| - pre-push | |||
There was a problem hiding this comment.
I was getting strong deprecation warnings from the pre-commit tooling on this (and there was an auto migration command, which was rather nice of them to have)
wagoodman
commented
Nov 14, 2024
Comment on lines
+51
to
+54
| "processor": { | ||
| "type": "string", | ||
| "description": "the application that created the workspace, formatted as 'name@version'" | ||
| }, |
There was a problem hiding this comment.
This is what was added relative to the last schema
wagoodman
commented
Nov 14, 2024
Comment on lines
+52
to
+61
| try: | ||
| from importlib import metadata | ||
| except ImportError: | ||
| # Python < 3.8 | ||
| import importlib_metadata as metadata | ||
|
|
||
| try: | ||
| if not metadata: | ||
| raise metadata.PackageNotFoundError | ||
| version = metadata.version(package_name) |
There was a problem hiding this comment.
this is how you can reflect package version information rather than use hard coded strings
kzantow
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds vunnel version information to workspace output, so we know which version of vunnel did the processing of the upstream data. This is related to grype DB v6 work so that we have more detail on a provider-level on how the data was handled upstream.