Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AM - Renovacion Matricula: act. datos de contactos #1928

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

AM - Renovacion Matricula: act. datos de contactos #1928

wants to merge 1 commit into from

Conversation

Fabio-Ramirez
Copy link
Contributor

Requerimiento

https://proyectos.andes.gob.ar/browse/AM-296

Funcionalidad desarrollada

  1. Se realizan cambios de contactos en las colecciones authUsers, Profesional y pacienteApp.
  2. Al momento de renovar la matricula, el profesional tenga la posibilidad desde la mobile, modificar su contacto

UserStories llegó a completarse

  • Si
  • No

Requiere actualizaciones en la base de datos

  • Si
  • No

@Fabio-Ramirez Fabio-Ramirez requested review from a team as code owners July 22, 2024 00:00
@Fabio-Ramirez Fabio-Ramirez mentioned this pull request Jul 22, 2024
Open
9 tasks
silviroa
silviroa requested changes Oct 23, 2024
View reviewed changes
core/tm/routes/profesional.ts
req
);
}
profesional.contactos = req.body.domiciliosMobile.contactos ? req.body.domiciliosMobile.contactos : profesional.contactos;
profesional.domicilios = req.body.domicilios ? req.body.domicilios : req.body.domiciliosMobile.domicilios;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Si se llama desde matriculaciones el campo domiciliosMobile no llega, por lo que habría que agregar un control.
En el caso. de domicilios si no llega ese campo. se va a pisar con un null lo que tenga registrado. el profesional antes del update

@silviroa silviroa added the changes requested Se solicitaron cambios label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silviroa silviroa silviroa requested changes

@ma7payne ma7payne Awaiting requested review from ma7payne ma7payne is a code owner automatically assigned from andes/code-review

@MarianoCampetella MarianoCampetella Awaiting requested review from MarianoCampetella MarianoCampetella is a code owner automatically assigned from andes/code-review

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
changes requested Se solicitaron cambios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fabio-Ramirez @silviroa