Meal plan tab #48
Closed
Meal plan tab #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Week still under- and overflows. Also editable data persists between weeks, should instead be assigned to one week. And landing week is 1 off.
…for 2023 Days in 2024 is not shown properly and cba fixing
Updating mealplan
UnluckyBird
approved these changes
Nov 24, 2023
|
Fix using |
UnluckyBird
reviewed
Nov 29, 2023
| /> | ||
| </Pressable> | ||
| </View> | ||
| <View style={styles.weekdaysContainer}>{renderDays()}</View> |
There was a problem hiding this comment.
You can make this a ScrollView, then you just need to set the dayContainer height on initial load
There was a problem hiding this comment.
Will look into it 🫡
|
There are som issues with how dates are calculated. Will open a pull request later, using Moment.js |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #20
Days are editable and the data is locally stored for each day. It is possible to change week.
Note that changing year shows incorrect day dates (not important).
Furthermore, comments have been added where the GunDB implementation should be.