Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented GunDB on list view and removed all dummy data #75

Merged
merged 4 commits into from
Dec 11, 2023

Conversation

UnluckyBird
Copy link
Collaborator

Implemented GunDB on list view
Removed dummy data
Made list view more stable

@emilnormann
Copy link
Collaborator

Måske lidt overkill at have årstal på hvornår det blev tilføjet til indkøbslisten.
Tænker det skal implementeres med det reele gruppesystem når det er inde, men ellers lgtm.

handlers/list.ts Outdated Show resolved Hide resolved
handlers/list.ts Outdated Show resolved Hide resolved
Copy link
Owner

@andreasalstrup andreasalstrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM efter fix

handlers/list.ts Outdated Show resolved Hide resolved
handlers/list.ts Outdated Show resolved Hide resolved
Made properties for username and groupid
made functions void
used this.
Copy link
Owner

@andreasalstrup andreasalstrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreasalstrup andreasalstrup merged commit 9675d1a into main Dec 11, 2023
1 check passed
@andreasalstrup andreasalstrup deleted the list-gundb branch December 11, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants