Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notice Board and QR codes #86

Merged
merged 15 commits into from
Dec 17, 2023
Merged

Notice Board and QR codes #86

merged 15 commits into from
Dec 17, 2023

Conversation

UnluckyBird
Copy link
Collaborator

@UnluckyBird UnluckyBird commented Dec 16, 2023 •
edited
Loading

DO NOT USE DEFAULT 12345678 USER(I broke him)

Hooked up notice board to GunDB
Show QR code in notice board
Allow for QR code scanning when joining group

For testing you can use the users 44444444 or 66666666 or create new ones
Can be test using the QR code
386845463_865989015307943_5799791996546069278_n

@UnluckyBird
Hook notice board and QR codes
7425b46 
Hooked up notice board to gunDB
Show QR code in notice board
Allow for QR code scanning when joining group
@UnluckyBird
Whitespace
0e22e44
@andreasalstrup
Copy link
Owner

Okay HUGE!

andreasalstrup
andreasalstrup approved these changes Dec 16, 2023
View reviewed changes
Copy link
Owner

@andreasalstrup andreasalstrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with multiple new users and it just works!

@andreasalstrup
Copy link
Owner

Mindre bug efter cold boot: Contact Information bliver kun vist for bruger der logger ind.
Contact Information bliver vist normalt efter logout og login igen.

@UnluckyBird
Copy link
Collaborator Author

Mindre bug efter cold boot: Contact Information bliver kun vist for bruger der logger ind. Contact Information bliver vist normalt efter logout og login igen.

Has been Fixed

@andreasalstrup
Copy link
Owner

Clicking Expenses gives:
ERROR TypeError: callback is not a function (it is 'd70da490-bf0c-4a69-b6ad-6f969834305e'), js engine: hermes

@andreasalstrup
Copy link
Owner

New QR
Screenshot_20231217-135324.png

@UnluckyBird
Copy link
Collaborator Author

Clicking Expenses gives: ERROR TypeError: callback is not a function (it is 'd70da490-bf0c-4a69-b6ad-6f969834305e'), js engine: hermes

Woops my bad, is fixed

@andreasalstrup
Copy link
Owner

Funny bug when editing mid sentence in the rules section.
Screenshot_20231217-142910.png

(not a breaking bug)

@andreasalstrup
Copy link
Owner

Looks very good to me!

@emilnormann
Copy link
Collaborator

Screenshot_2023-12-17-15-47-38-98_f73b71075b1de7323614b647fe394240
Med langt gruppenavn er qr basically offscreen og meget svær at trykke på.

@andreasalstrup
Copy link
Owner

Få en telefon med bedre opløsning Emil

@emilnormann
Copy link
Collaborator

Knappen 'Join by group id' kunne måske også omdøbes til at inkludere qr

@UnluckyBird
Copy link
Collaborator Author

Knappen 'Join by group id' kunne måske også omdøbes til at inkludere qr

Ehh disagree, the QR code is still just a groupId, and will not show if you haven't given the app permission to use camera

@UnluckyBird
Copy link
Collaborator Author

Med langt gruppenavn er qr basically offscreen og meget svær at trykke på.

Have changed Group ID to ID to make more space, and made text otherwise wrap instead of going off screen

@andreasalstrup andreasalstrup merged commit b2fde0d into main Dec 17, 2023
1 check passed
@andreasalstrup andreasalstrup deleted the qr-and-notice branch December 17, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilnormann emilnormann emilnormann approved these changes

@andreasalstrup andreasalstrup andreasalstrup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@UnluckyBird @andreasalstrup @emilnormann