Reverting update to DataStore 1.1.1 due to failing unit tests #1659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combined test coverage report
|
|
And the next issue is related to the badging process: #1647 (comment) |
dturner
force-pushed
the
dt/revert-datastore-upgrade
branch
from
8f275df
to
f98448a
Compare
Combined test coverage report
|
|
Thanks for the fix @SimonMarquis. This is no longer required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update to DataStore 1.1.1 caused the build to fail: https://github.com/android/nowinandroid/actions/runs/10990714827/job/30511531410
Downgrading to 1.0.0 to investigate. Almost certainly due to the performance improvement introduced here: https://developer.android.com/jetpack/androidx/releases/datastore#1.1.0-beta02
Although the suggested fix (also applied in this PR) to use
testScope.backgroundScopedoes not resolve the issue.