Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user-facing API to set password for user creation #425

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lukasmwerner
Copy link

Description

Previously, a bug existed that would not allow the API user to set the new user's password.

Information that is useful here:

  • The What: Adding JSON password field
  • The Why: This will allow the user to set the password field for the user creation
  • Type of change: This is a bugfix
  • Breaking change: Should be non-breaking
  • Jira Version + Type: JIRA 8.13.0: on-prem

Example:

Let us know how users can use or test this functionality.

// Example code
client.User.Create(&jira.User{
		EmailAddress: "[email protected]",
		DisplayName:  "example-user",
		Name:         "example-user",
		Password:     "this-is-a-bad-password-example",
}) // this will actually create the user with the given password

Checklist

Previously there existed a bug that would not allow the API user to actually set the new user's password.
@andygrunwald
Copy link
Owner

Hey,

I am very sorry that this pull request has been open for a long time with no final feedback or merge/decline. We work on this project in our spare time, and sometimes, other priorities take over. This is the typical open source dilemma.

However, there is news: We are kicking off v2 of this library 🚀

To provide visibility, we created the Road to v2 Milestone and calling for your feedback in #489

The development will take some time; however, I hope you can benefit from the changes.
If you seek priority development for your pull request + you like to sponsor it, please contact me.

What does this mean for my pull request?

We will work on this pull request indirectly.
We might merge it during the development or pull parts of it into the new version.
This means that during the development phase, we aim to tackle it.
Maybe in a different way like it is currently handled.
Please understand that this will take a while because we are running this in our spare time.

Final words

Thanks for using and contributing to this library.
If there is anything else you would like to tell us, let us know!

@github-actions github-actions bot added the conflicts Indicates merge conflicts label Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicts Indicates merge conflicts waiting for feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants