Skip to content
This repository has been archived by the owner on Dec 22, 2018. It is now read-only.

Update touchnode to use object due to deprecation in Gatsby v2 #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gil--
Copy link

@gil-- gil-- commented Aug 25, 2018

See https://next.gatsbyjs.org/docs/actions/#touchNode

Note: The plugin still works, it just spits out a bunch of deprecation warnings.

Calling "touchNode" with a nodeId is deprecated. Please pass an object containing a nodeId instead: touchNode({ nodeId: 'a-node-id' })
"touchNode" was called by gatsby-source-shopify
Calling "touchNode" with a nodeId is deprecated. Please pass an object containing a nodeId instead: touchNode({ nodeId: 'a-node-id' })

I'm guessing this would break v1 compatibility? Not sure if there's a more graceful way to support v1 or if plugins will simply stop supporting Gatsby v1

@gil-- gil-- mentioned this pull request Aug 25, 2018
@camsloanftc
Copy link

@angeloashmore - would it be possible to get eyes on this?

@angeloashmore
Copy link
Owner

@camsloanftc Leaving for work now, but I'll take a look at this tonight and tomorrow morning 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants