-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional normalization for generic_cell_clustering.ipynb #1027
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment about notebook documentatio
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just one small typo in the jupyter notebook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only added a minor comment on some wording. PR looks good to me.
If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
Closes #1000. Make the 99.9 percentile normalization in cell clustering optional.
How did you implement your changes
Adds a
normalize
flag totrain_cell_SOM
and in the CellSOMCluster class which is defaulted to True.Changing this arg to False will not conduct 99.9 percentile normalization on the data before cell clustering.
Remaining issues
N/A