Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional normalization for generic_cell_clustering.ipynb #1027

Merged
merged 9 commits into from
Aug 2, 2023

Conversation

camisowers
Copy link
Contributor

If you haven't already, please read through our contributing guidelines before opening your PR

What is the purpose of this PR?
Closes #1000. Make the 99.9 percentile normalization in cell clustering optional.

How did you implement your changes
Adds a normalize flag to train_cell_SOM and in the CellSOMCluster class which is defaulted to True.
Changing this arg to False will not conduct 99.9 percentile normalization on the data before cell clustering.

Remaining issues
N/A

@camisowers camisowers added the enhancement New feature or request label Jul 25, 2023
@camisowers camisowers self-assigned this Jul 25, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@camisowers camisowers marked this pull request as ready for review July 25, 2023 21:24
Copy link
Contributor

@alex-l-kong alex-l-kong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about notebook documentatio

Copy link
Contributor

@cliu72 cliu72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one small typo in the jupyter notebook

Copy link

@JLrumberger JLrumberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only added a minor comment on some wording. PR looks good to me.

@camisowers camisowers added this pull request to the merge queue Aug 2, 2023
Merged via the queue into main with commit 94e6363 Aug 2, 2023
16 checks passed
@camisowers camisowers deleted the optional_normalization branch August 2, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make 99.9 normalization optional on function cell_som_clustering.train_cell_som
6 participants