Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1119 reducing time to merge in merge maskspy wi ez segmenter #1123

Merged
merged 9 commits into from
Mar 15, 2024
Merged

1119 reducing time to merge in merge maskspy wi ez segmenter #1123

merged 9 commits into from
Mar 15, 2024

Conversation

bryjcannon
Copy link
Contributor

Resolves #1119

@bryjcannon bryjcannon self-assigned this Mar 7, 2024
@bryjcannon bryjcannon linked an issue Mar 7, 2024 that may be closed by this pull request
Reducing time to merge in merge_masks.py w/i ez_segmenter #1119
Closed
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@bryjcannon bryjcannon requested review from srivarra and removed request for alex-l-kong March 8, 2024 06:00
srivarra
srivarra requested changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@srivarra srivarra left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! just a few small changes, and some suggestions (which you don't have to take into consideration) if you'd like to bump performance to another level with Pandas.

src/ark/segmentation/ez_seg/merge_masks.py Outdated Show resolved Hide resolved
src/ark/segmentation/ez_seg/merge_masks.py Outdated Show resolved Hide resolved
src/ark/segmentation/ez_seg/merge_masks.py Outdated Show resolved Hide resolved
src/ark/segmentation/ez_seg/merge_masks.py Outdated Show resolved Hide resolved
src/ark/segmentation/ez_seg/merge_masks.py Show resolved Hide resolved
srivarra
srivarra approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@srivarra srivarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@bryjcannon bryjcannon added this pull request to the merge queue Mar 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 14, 2024
@srivarra srivarra added this pull request to the merge queue Mar 15, 2024
Merged via the queue into main with commit 10aa4a1 Mar 15, 2024
18 checks passed
@srivarra srivarra deleted the 1119-reducing-time-to-merge-in-merge_maskspy-wi-ez_segmenter branch March 15, 2024 19:41
@srivarra srivarra added the enhancement New feature or request label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srivarra srivarra srivarra approved these changes

Assignees

@bryjcannon bryjcannon

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reducing time to merge in merge_masks.py w/i ez_segmenter
2 participants
@bryjcannon @srivarra