-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual mask names #1126
Merged
Merged
Manual mask names #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
srivarra
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!!
Code looks good with, just need to update the example_dataset and can then merge with main. |
@camisowers Dataset is updated, this is good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
Closes #1125.
Currently if
nuclear_counts=True
, the nuclear counts are calculated in a loop for each mask (large/unnecessary computation burden for many ezseg masks).The cell table creates it's own set of rows for the nuclear masks according to the ezseg logic, while also having a second set of columns suffixed with _nuclear using traditional cell table logic. We want to remove the duplicated nuclear expression values, as well as saving the computational effort.
How did you implement your changes
mask_types
as an optional argument togenerate_cell_table()
detailing which masks to extract expression data for; the default is set to ['whole_cell'].Remaining issues
Add manual mask name specification into the ez segmenter notebook. @bryjcannon