Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Docker Builds #1168

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Removed Docker Builds #1168

merged 4 commits into from
Oct 17, 2024

Conversation

srivarra
Copy link
Contributor

If you haven't already, please read through our contributing guidelines before opening your PR

What is the purpose of this PR?

Docker is no longer necessary for Ark Analysis. Windows users can now completely use Ark Analysis without Docker or on WSL.

How did you implement your changes

This PR removes the Dockerfile and docker workflows from the repository, along with documentation for how to use Ark with Docker.
Remaining issues

N/A

@srivarra srivarra linked an issue Oct 11, 2024 that may be closed by this pull request
@srivarra srivarra self-assigned this Oct 11, 2024
@srivarra srivarra added the dependencies Pull requests that update a dependency file label Oct 11, 2024
@srivarra srivarra marked this pull request as ready for review October 11, 2024 17:22
Copy link
Contributor

@camisowers camisowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One minor suggestion.

docs/_rtd/faq.md Show resolved Hide resolved
Copy link
Contributor

@alex-l-kong alex-l-kong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One additional section that could be removed.

docs/_rtd/windows_setup.md Outdated Show resolved Hide resolved
Copy link
Contributor

@alex-l-kong alex-l-kong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@srivarra srivarra added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit b26713b Oct 17, 2024
9 checks passed
@srivarra srivarra deleted the remove_docker branch October 17, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Docker
3 participants