Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/build): allow direct bundling of TSX files with application builder #28643

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

clydin
Copy link
Member

@clydin clydin commented Oct 15, 2024

When using the application builder with isolatedModules, the bundler will directly handle TypeScript transpilation and bundling. Previously, any input TSX files were loaded by the bundler as TS files. This difference caused errors when attempting to process the files since the syntax differs between TSX and TS. The appropriate loader will now be used if the input file is TSX in this situation.

Closes #28640

…ion builder

When using the application builder with `isolatedModules`, the bundler will
directly handle TypeScript transpilation and bundling. Previously, any input
TSX files were loaded by the bundler as TS files. This difference caused errors
when attempting to process the files since the syntax differs between TSX and TS.
The appropriate loader will now be used if the input file is TSX in this situation.
@clydin clydin added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Oct 15, 2024
@clydin clydin merged commit 13b65df into angular:main Oct 16, 2024
33 checks passed
@clydin
Copy link
Member Author

clydin commented Oct 16, 2024

The changes were merged into the following branches: main, 18.2.x

@clydin clydin deleted the application/tsx-direct branch October 16, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/build target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't compile on React components on production with Vite but works on development
2 participants