fix(elementexplorer): setting the browser root element #3538

cnishina · 2016-09-09T22:27:53Z

- provide logging messages to useAllAngular2AppRoots - provide logging messages to set the root element closes angular#3465

cnishina · 2016-09-12T17:20:55Z

This is CLI driven but there are cases where this issue is not resolved for downstream projects like elementor.

juliemr · 2016-09-12T18:34:09Z

We talked about this offline, and the conclusion for now is:

If the user has not specified how to search for angular, have element explorer look on body and then try useAllAngular2AppRoots (a.k.a rootEl = ''). This will let element explorer work without configuration for 90% of apps.
Let's rethink the API here, since the question "how do I find Angular on my page" is getting messy and prompting questions from users. It's not obvious that the cryptically named useAllAngular2AppRoots has anything to do with rootEl, and people don't know how to use it.

cnishina · 2016-09-19T07:32:36Z

Closing in favor of #3570.

googlebot added the cla: yes label Sep 9, 2016

cnishina added this to the 4.1.0 milestone Sep 9, 2016

cnishina added the pr: needs review label Sep 9, 2016

fix(elementexplorer): setting the browser root element

7e593e3

- provide logging messages to useAllAngular2AppRoots - provide logging messages to set the root element closes angular#3465

cnishina force-pushed the elementexplorer_ng2 branch from 30a2248 to 7e593e3 Compare September 9, 2016 23:27

cnishina changed the title ~~fix(elementexplorer): check for an element with all angular 2 app roots~~ fix(elementexplorer): setting the browser root element Sep 10, 2016

cnishina added type: discussion pr: controversial and removed pr: needs review labels Sep 12, 2016

cnishina closed this Sep 19, 2016

cnishina deleted the elementexplorer_ng2 branch November 5, 2018 17:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(elementexplorer): setting the browser root element #3538

fix(elementexplorer): setting the browser root element #3538

cnishina commented Sep 9, 2016

cnishina commented Sep 12, 2016

juliemr commented Sep 12, 2016 •

edited

Loading

cnishina commented Sep 19, 2016

fix(elementexplorer): setting the browser root element #3538

fix(elementexplorer): setting the browser root element #3538

Conversation

cnishina commented Sep 9, 2016

cnishina commented Sep 12, 2016

juliemr commented Sep 12, 2016 • edited Loading

cnishina commented Sep 19, 2016

juliemr commented Sep 12, 2016 •

edited

Loading