Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ANGLE on macOS #239

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support ANGLE on macOS #239

wants to merge 1 commit into from

Conversation

akihikodaki
Copy link

No description provided.

@Quackdoc Quackdoc mentioned this pull request May 21, 2021
Open
@lbibass
Copy link

lbibass commented May 29, 2021

Any updates on getting this pulled in?

ebassi
ebassi reviewed May 29, 2021
View reviewed changes
meson.build Show resolved Hide resolved
@lbibass
Copy link

lbibass commented Aug 29, 2021

Checking in on getting this merged into master again! Would really love to see it.

@ebassi
Copy link
Collaborator

ebassi commented Aug 30, 2021

This will not get merged, unless the issue on Windows is solved.

t0rr3sp3dr0
t0rr3sp3dr0 reviewed Sep 21, 2021
View reviewed changes
Copy link

@t0rr3sp3dr0 t0rr3sp3dr0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would these suggested changes be enough to get this PR merged?

meson.build Show resolved Hide resolved
meson.build Outdated Show resolved Hide resolved
meson.build Outdated Show resolved Hide resolved
@akihikodaki
Copy link
Author

Would these suggested changes be enough to get this PR merged?

I need an answer for #239 (comment).

@akihikodaki
Copy link
Author

This pull request should be now ready for reviews by maintainers.

@melroy89
Copy link

melroy89 commented Mar 2, 2022

@ebassi please take a second look.

@akihikodaki
Copy link
Author

8611b07: rebased to c84bc94.

@akihikodaki
Copy link
Author

@ebassi Hi, it's been three years since this was submitted. Can you take a look at this?

ebassi
ebassi reviewed Mar 20, 2024
View reviewed changes
meson.build Outdated Show resolved Hide resolved
ebassi
ebassi reviewed Mar 20, 2024
View reviewed changes
meson.build Outdated Show resolved Hide resolved
ebassi
ebassi reviewed Mar 20, 2024
View reviewed changes
meson.build Outdated Show resolved Hide resolved
@ebassi
Copy link
Collaborator

ebassi commented Mar 20, 2024

Two minor changes to limit DLL checks on Windows.

@akihikodaki
Copy link
Author

Two minor changes to limit DLL checks on Windows.

Applied with commit b0d6d60.

Fahien
Fahien reviewed May 20, 2024
View reviewed changes
meson.build Outdated Show resolved Hide resolved
avoidik
avoidik reviewed May 29, 2024
View reviewed changes
meson.build Outdated Show resolved Hide resolved
@akihikodaki
Copy link
Author

9fdedad: Replaced host_machine with host_system.

@avoidik
Copy link

avoidik commented Jun 15, 2024

@ebassi could you please approve this workflow?

@akihikodaki
Improve library detections
a039af2 
Now it automatically finds files from Qt 5 and supports the upstream
ANGLE on Windows and macOS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebassi ebassi ebassi left review comments

@Fahien Fahien Fahien left review comments

@avoidik avoidik avoidik left review comments

@t0rr3sp3dr0 t0rr3sp3dr0 t0rr3sp3dr0 left review comments

@fanc999 fanc999 fanc999 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@akihikodaki @lbibass @ebassi @melroy89 @avoidik @Fahien @t0rr3sp3dr0 @fanc999