[cliconf] changes required after cliconfbase updates in ansible.netcommon#640 #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: NilashishC <[email protected]>
NilashishC
changed the title
NilashishC
changed the title
NilashishC
added
the
skip-changelog
roverflow
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
err_responsescannot be added in edit_config base signature, this breaks other platforms. The fact that edit_config base hasdiffkwarg and nxos cliconf edit_config doesn't results in sanity/pylint to trip iferr_responsesisn't added in edit_config base.ISSUE TYPE
COMPONENT NAME
cliconf/nxos.py