Add markuman as a collection maintainer to BOTMETA #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
feature
tremble
approved these changes
Jul 8, 2021
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
Add markuman as a collection maintainer to BOTMETA SUMMARY Add @markuman to BOTMETA.yml team_aws Fixes ansible-collections#627 ISSUE TYPE Feature Pull Request COMPONENT NAME BOTMETA.tml ADDITIONAL INFORMATION 2 maintainers have voted +1 in linked issue. Thanks for all your contributions @markuman, glad to have you aboard! Reviewed-by: Mark Chappell <None>
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
Add markuman as a collection maintainer to BOTMETA SUMMARY Add @markuman to BOTMETA.yml team_aws Fixes ansible-collections#627 ISSUE TYPE Feature Pull Request COMPONENT NAME BOTMETA.tml ADDITIONAL INFORMATION 2 maintainers have voted +1 in linked issue. Thanks for all your contributions @markuman, glad to have you aboard! Reviewed-by: Mark Chappell <None>
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
…lections#628) (ansible-collections#783) Add support for icmp_type and icmp_code parameters (close ansible-collections#628) SUMMARY This pull request add support for new icmp_type and icmp_code parameters with proto: icmp or proto: icmpv6. This initial suggestion was aimed at closing the inconsistency when the meaning of from_port and to_port would change based on the protocol type. Fixes ansible-collections#628 ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_group Reviewed-by: Alina Buzachis <None> Reviewed-by: Raz M. <None> Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add @markuman to BOTMETA.yml
team_awsFixes #627
ISSUE TYPE
COMPONENT NAME
BOTMETA.tml
ADDITIONAL INFORMATION
2 maintainers have voted +1 in linked issue.
Thanks for all your contributions @markuman, glad to have you aboard!