Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mattermost: add support for message priority #9087

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

bluikko
Copy link
Contributor

@bluikko bluikko commented Oct 31, 2024

SUMMARY

Add support for module parameter priority that is passed to Mattermost server for Message Priority feature.

Fixes #9068

Also add a missing closing parenthesis to docs.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

mattermost

ADDITIONAL INFORMATION

@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module plugins plugin (any type) labels Oct 31, 2024
Co-authored-by: Alexei Znamensky <[email protected]>
@bluikko
Copy link
Contributor Author

bluikko commented Oct 31, 2024

Any comment on which version this might be included -- if it is deemed suitable for merging?
This way I could add the version_added field to priority parameter docs.

@russoz
Copy link
Collaborator

russoz commented Oct 31, 2024

Any comment on which version this might be included -- if it is deemed suitable for merging? This way I could add the version_added field to priority parameter docs.

That would be 10.0.0 - thanks for checking

@bluikko
Copy link
Contributor Author

bluikko commented Oct 31, 2024

Any comment on which version this might be included -- if it is deemed suitable for merging? This way I could add the version_added field to priority parameter docs.

That would be 10.0.0 - thanks for checking

Thanks. I recall having to wait for a "non-patch level" (major/minor) for new features in the past and I'm not sure what version is planned next. Will add that in the commit as well.

Validate the two possible priorities with choices.
Add priority arg to one example and add version_added
field for the arg docs.
@felixfontein felixfontein added the check-before-release PR will be looked at again shortly before release and merged if possible. label Oct 31, 2024
@felixfontein
Copy link
Collaborator

Thanks. I recall having to wait for a "non-patch level" (major/minor) for new features in the past and I'm not sure what version is planned next. Will add that in the commit as well.

Usually #582 has information on when the next major/minor/patch releases will happen (and thus also which next minor/major release will there be). I apparently forgot to update the top post the last time (it's updated now), but if you scroll to the end you find that information as well, just a bit spread out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
check-before-release PR will be looked at again shortly before release and merged if possible. feature This issue/PR relates to a feature request module module plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mattermost: Support "Message Priority" parameter
4 participants