use loop to remove items

ansible-collections · Apr 19, 2022 · c6714fc · c6714fc
1 parent d4af773
commit c6714fc
Showing 1 changed file with 4 additions and 16 deletions.
diff --git a/plugins/modules/grafana_folder.py b/plugins/modules/grafana_folder.py
@@ -295,23 +295,11 @@ def delete_folder(self, folder_uid):
     def get_folder_permission(self, folder_uid):
         url = "/api/folders/{folder_uid}/permissions".format(folder_uid=folder_uid)
         response = self._send_request(url, headers=self.headers, method="GET")
+        KEYS_TO_REMOVE = ['created', 'inherited', 'slug', 'teamAvatarUrl', 'teamEmail', 'title', 'uid', 'updated', 'url',
+                          'userAvatarUrl', 'userEmail', 'userLogin', 'folderId', 'permissionName', 'team', 'isFolder']
         for items in response:
-            del items['created']
-            del items['inherited']
-            del items['slug']
-            del items['teamAvatarUrl']
-            del items['teamEmail']
-            del items['title']
-            del items['uid']
-            del items['updated']
-            del items['url']
-            del items['userAvatarUrl']
-            del items['userEmail']
-            del items['userLogin']
-            del items['folderId']
-            del items['permissionName']
-            del items['team']
-            del items['isFolder']
+            for k in KEYS_TO_REMOVE:
+                del items[k]
             if items['userId'] == 0:
                 del items['userId']
             if items['teamId'] == 0: