Better idempotence report when creating a dashboard in a folder #168
Conversation
This generates smaller diff if we want to modify it and run various tests with variants
This enables us to stop having a task reported as changed when uploading a dashboard repeatedly in a folder that is not the main folder. The grafana API doesn't return the 'folderId', and thus we would previously always be reported as 'changed'.
Codecov Report
@@ Coverage Diff @@
## main #168 +/- ##
=======================================
Coverage ? 72.50%
=======================================
Files ? 7
Lines ? 702
Branches ? 75
=======================================
Hits ? 509
Misses ? 176
Partials ? 17 Continue to review full report at Codecov.
|
|
Another solution would be first ot get the dashboard by |
|
Hi @BenjaminSchubert ! I think that first looking for the dashboard by uuid and then by title would indeed avoid having a match by title while we have an uuid match later on. I gladly accept the improvement ! |
SUMMARY
Previously, whenever you would upload a dashboard to a custom folder, the status would always be reported as
changed, as thefolderIdis never included in the return value, but was in ourpayload.The current solution is not perfect, but would at least not report
changedwhen nothing changed, and should not break any other workflows.ISSUE TYPE
COMPONENT NAME
grafana_dashboard
ADDITIONAL INFORMATION
In order to understand and reproduce the issue, running the added integration test without the patch would fail, as the second upload would fail.
For context, grafana/grafana#12491 is also relevant