Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: grafana version sorting #378

Merged
merged 2 commits into from
Jun 16, 2024
Merged

fix: grafana version sorting #378

merged 2 commits into from
Jun 16, 2024

Conversation

Nemental
Copy link
Collaborator

@Nemental Nemental commented Jun 16, 2024 •
edited
Loading

SUMMARY

#377 reveals an error in the version sorting, so that grafana 11.0.0 is not one of the 3 current major versions

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION
❯ python hacking/find_grafana_versions.py
["11.0.0", "10.4.4", "9.5.19"]

@Nemental Nemental marked this pull request as ready for review June 16, 2024 11:04
@Nemental Nemental requested review from rrey and seuf as code owners June 16, 2024 11:04
@Nemental Nemental requested a review from rndmh3ro June 16, 2024 11:04
@Nemental Nemental enabled auto-merge (rebase) June 16, 2024 11:04
@Nemental Nemental merged commit 793df2c into main Jun 16, 2024
29 checks passed
@Nemental Nemental deleted the fix/grafana-version-sort branch June 16, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rndmh3ro rndmh3ro rndmh3ro approved these changes

@rrey rrey Awaiting requested review from rrey rrey is a code owner

@seuf seuf Awaiting requested review from seuf seuf is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nemental @rndmh3ro