-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support headers in queue_declare function #174
base: main
Are you sure you want to change the base?
Conversation
@Andersson007 @csmart could I get a review of this please? |
@V4UIDev hello, thanks for the PR!
|
@V4UIDev thanks for the contribution and fixing up this missing component! I think some tests would be great, if you have the time. That will help us to keep on top of this in the future. Thanks! |
@V4UIDev if you have any questions, please let us know |
@csmart do you think if we can merge the PR w/o the requested integration tests as the author does not respond if i add the fragment in another PR? if you think it's dangerous, we could wait/close the PR, np |
@Andersson007 @csmart Apologies for the delay. Changelog fragment and integration tests added, let me know if they need any further tweaking. Thanks! |
will be happy to review the PR again once the integration tests are green, thanks! |
Yes, I think there is a rate limit that cloudsmith impose on rabbitmq so will put in a commit next month :) |
SUMMARY
Add headers when running the declare queue function.
ISSUE TYPE
COMPONENT NAME
RabbitMQ Publish
basic_publish
ADDITIONAL INFORMATION
When running the following Ansible task:
The task would fail adding the message to the queue, due to the headers not being passed in correctly. This pull request addresses that and adds the headers to the message.
Before:
After:
It has also been tested without passing in headers, and the play still functions as before.